Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add support for polars #87

Merged
merged 52 commits into from
Apr 18, 2023
Merged

refactor: add support for polars #87

merged 52 commits into from
Apr 18, 2023

Conversation

premsrii
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #87 (68c8e52) into develop (c493677) will decrease coverage by 4.64%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
- Coverage    99.42%   94.79%   -4.64%     
===========================================
  Files            8        8              
  Lines          519      480      -39     
===========================================
- Hits           516      455      -61     
- Misses           3       25      +22     
Impacted Files Coverage Δ
src/sk_transformers/datetime_transformer.py 100.00% <100.00%> (ø)
src/sk_transformers/generic_transformer.py 100.00% <100.00%> (+0.52%) ⬆️
src/sk_transformers/string_transformer.py 79.67% <100.00%> (-18.82%) ⬇️
src/sk_transformers/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@premsrii premsrii marked this pull request as ready for review February 21, 2023 12:39
@premsrii premsrii marked this pull request as draft February 21, 2023 14:46
@chrislemke
Copy link
Owner

I just discovered that the | as a short version of Union is only supported since Python 10. Sorry 🥺

chrislemke and others added 2 commits April 11, 2023 11:09
…ers into polars

# Conflicts:
#	.pre-commit-config.yaml
#	poetry.lock
#	requirements.txt
#	src/sk_transformers/generic_transformer.py
#	src/sk_transformers/string_transformer.py
@chrislemke chrislemke closed this Apr 11, 2023
@chrislemke chrislemke reopened this Apr 11, 2023
@chrislemke chrislemke closed this Apr 11, 2023
@chrislemke chrislemke reopened this Apr 11, 2023
@chrislemke chrislemke closed this Apr 17, 2023
@chrislemke chrislemke reopened this Apr 17, 2023
chrislemke
chrislemke previously approved these changes Apr 18, 2023
@premsrii premsrii marked this pull request as ready for review April 18, 2023 14:07
@chrislemke chrislemke closed this Apr 18, 2023
@chrislemke chrislemke reopened this Apr 18, 2023
@chrislemke chrislemke closed this Apr 18, 2023
@chrislemke chrislemke reopened this Apr 18, 2023
@chrislemke chrislemke merged commit b831485 into develop Apr 18, 2023
@chrislemke chrislemke deleted the polars branch April 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants