Fix regression on bigendian #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
commented
Jun 5, 2023
|
Perhaps For ex, PHP use its own function, see https://github.com/php/php-src/blob/php-8.2.6/build/php.m4#L1691 |
|
Or the gcc (and other compilers) define The |
|
@remicollet : would you adjust your PR according to @sharkcz comments? Then I will wait creating RPMs. |
- rewrite IP2Location_read32_row - more robust detection of endianness using WORDS_BIGENDIAN from AC_C_BIGENDIAN
|
Scratch build seems OK https://koji.fedoraproject.org/koji/taskinfo?taskID=101826163 PR updated |
pbiering
approved these changes
Jun 5, 2023
|
8.6.0 with this patch submitted now for update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora scratch build using this fix:
https://koji.fedoraproject.org/koji/taskinfo?taskID=101823859
Fix #57