Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation: S3/GS files shouldn't need to touch disk #192

Open
JensRantil opened this issue Oct 25, 2020 · 0 comments
Open

Optimisation: S3/GS files shouldn't need to touch disk #192

JensRantil opened this issue Oct 25, 2020 · 0 comments

Comments

@JensRantil
Copy link

I notice that the S3 and GS virtual file systems both copy the content first to disk. Strictly speaking, given that both APIs support range requests to fetch file content, I don't think they really need to touch disk at all. Instead they could be streamed straight over HTTP while still implementing

gleam/filesystem/vfs.go

Lines 20 to 25 in 53a6956

type VirtualFile interface {
io.ReaderAt
io.ReadCloser
io.Seeker
Size() int64
}
.

I guess temporarily storing to disk is a simpler implementation, though. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant