Skip colourisation for dumb terminals #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumb terminals can only interpret a limited number of control codes,
and colour codes will be written as plain text (garbage) on these
terminals.
This can be tested with making sure the following program only
outputs “ERROR: dumb”:
node -e 'require("./cli.js").error("dumb")'
|
@chriso Any chance you could look at this? |
|
Sorry for the epic delay. |
chriso
added a commit
that referenced
this pull request
Jul 29, 2015
Skip colourisation for dumb terminals
|
Available in |
|
Thank you very much! This is (eventually) going to make using Node.js a whole lot better for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumb terminals can only interpret a limited number of control codes, and colour escape codes will be written as plain text (garbage) on these terminals.
This can be tested with making sure the following program only outputs “ERROR: dumb”: