Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Buffer prototype with buffertools. #5

Closed
wants to merge 1 commit into from

Conversation

matinm
Copy link

@matinm matinm commented Apr 17, 2014

A recent change to buffertools modified the default behavior such that the Buffer prototype is no longer extended by default.

This PR ensures the Buffer prototype is extended in index.js.

See bnoordhuis/node-buffertools@20b1921.

@chriso
Copy link
Owner

chriso commented Apr 19, 2014

Thanks for the PR. There's probably a good reason for not extending Buffer and so I'll use the buffertools.concat(a, b) form instead.

@chriso chriso closed this Apr 19, 2014
chriso added a commit that referenced this pull request Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants