Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-UTF-8 encodings and fail gracefully with unexpected encoding #7

Open
chrispomeroyhale opened this issue Dec 2, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@chrispomeroyhale
Copy link
Owner

A customer was trying to import a Windows-1252 encoded document and the parser gets stuck in a loop when finding a bad encoding. For privacy reasons I will not post the particular document.

Two parts:

  1. At the very least, we should gracefully handle documents with unexpected encodings so that client apps don't hang and can display an error.
  2. Ideally support multiple encodings. Although we may expect modern CSV to be UTF-8 encoded, the whole idea of the CSV Dialect is interoperability with existing documents in their various flavors.
@chrispomeroyhale chrispomeroyhale added bug Something isn't working enhancement New feature or request labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant