Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 63: `Webpage shows a 'loading' wheel in tabs even when fu… #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Faleidel
Copy link

…lly loaded` by changing some contentDocument.write to creating scrip elements and appending them to the document.

Fixed opening the code editor making the page scroll vertically because the editor was taking a bit too much space.

…lly loaded` by changing some contentDocument.write to creating scrip elements and appending them to the document.

Fixed opening the code editor making the page scroll vertically because the editor was taking a bit too much space.
@chrispsn
Copy link
Owner

chrispsn commented Oct 2, 2019

Thank you for this! Is it necessary to put the code in app2.js or can it all be in the existing files?

@chrispsn
Copy link
Owner

chrispsn commented Oct 3, 2019

FYI - I separately committed the display fixes (thank you) as I need to think through the separate file thing.

@Faleidel
Copy link
Author

Faleidel commented Oct 3, 2019

It doesn't need an other file. I was under the impression that app.js needed to stay as it was to be reused in other context? I think I was just confused...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants