Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix for github provider for nullable names #35

Merged
merged 1 commit into from Nov 16, 2023

Conversation

atmonshi
Copy link
Sponsor Contributor

apparently, new github accounts don't have name, so it always returns null. unless the user sets one

apparently, new github accounts don't have `name`, so it always returns null.
unless the user sets one
Copy link
Owner

@chrisreedio chrisreedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (again! 🤣)

@chrisreedio chrisreedio self-assigned this Nov 16, 2023
@chrisreedio chrisreedio merged commit 74aeb6f into chrisreedio:3.x Nov 16, 2023
9 checks passed
@atmonshi atmonshi deleted the null-names branch November 16, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants