Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added post socialite hook and updated README #38

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

josh48202
Copy link

added post socialite hook for additional socialite validation and updated to match recent updates.

@chrisreedio
Copy link
Owner

@josh48202 I haven't forgot about this!

I'm completely swamped with work right now.

The good news is we're using Socialment in the project and it should be coming to a close in the first few weeks after the new year.

This should really allow me to give the new functionality a run for it's money and battle test it.

I am planning on getting this code in hopefully sooner rather than later.

Thanks again for submitting this and I do plan to get it in. Just wanted to let you know I hadn't forgotten about you!

@chrisreedio chrisreedio self-assigned this Dec 21, 2023
@chrisreedio chrisreedio added the enhancement New feature or request label Dec 21, 2023
@josh48202
Copy link
Author

loving all the new updates. just checking in on this.

@chrisreedio
Copy link
Owner

Hey @josh48202, lets catch up on this.

I reviewed this and wanted to get your thoughts on how I've implemented this in another 'glue' package I use on a few sites.

https://github.com/chrisreedio/socialment-bastion-azure/blob/3.x/src/SocialmentBastionAzureServiceProvider.php#L144

Here I do some checks to see if the user attempting to login can 'access the application'.

I've wanted to do a kind of 'plugin/addon' system for this package to enhance the functionality of specific drivers while keeping driver specific code out of the code.

Would love to hear any thoughts you have on this.

Also appreciate the kind words!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants