Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): typehint #42

Merged
merged 1 commit into from May 3, 2024
Merged

Conversation

pepperfm
Copy link
Contributor

@pepperfm pepperfm commented Mar 8, 2024

Hi there!

Here ive got an error, when trying to pass closure as parameter.

May be here should be inversed changes? (remove callable type from method params, not from properties)

@chrisreedio
Copy link
Owner

Can you explain these changes @pepperfm ?

You should have already been able to pass in a closure.

@pepperfm
Copy link
Contributor Author

pepperfm commented Apr 1, 2024

You should have already been able to pass in a closure.

function can accept the closure, right
but the class properties is only can be string or null: protected ?string $loginRoute = null;

so when i trying to pass closure, ive got an error

@pepperfm
Copy link
Contributor Author

pepperfm commented Apr 1, 2024

so when i trying to pass closure, ive got an error

on class-property level, not on function agrs

Copy link
Owner

@chrisreedio chrisreedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok to me!

@chrisreedio chrisreedio merged commit 19ae196 into chrisreedio:3.x May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants