Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support HTML lang tag #96

Merged
merged 2 commits into from Mar 13, 2021
Merged

support HTML lang tag #96

merged 2 commits into from Mar 13, 2021

Conversation

casperdcl
Copy link
Sponsor Contributor

A lang attribute is considered essential

@chrisrhymes
Copy link
Owner

Thanks for your pull request! Please can you change the below so there is a default lang for users that haven't set it in the _config.yml file.

{% if site.lang %}
 lang="{{ site.lang }}"{% endif %}

to

lang="{{ site.lang | default: 'en' }}"

@casperdcl
Copy link
Sponsor Contributor Author

casperdcl commented Mar 7, 2021

Yeah I wasn't too sure about setting this default because it may potentially change behaviour... e.g. a French site usually viewed on a browser configured to assume French by default will now be forced to assume English.

What do you think?

@chrisrhymes
Copy link
Owner

That's a very good point!

_layouts/default.html Outdated Show resolved Hide resolved
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants