Fix for macOS GUI optimization errors when file path includes spaces #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #30
dmg installer for testing is available: https://github.com/chrissimpkins/Crunch/tree/path-space-escape-fix/installer (v2.0.2-beta1)
This issue also applies to the macOS right-click menu service. Installation of the above build should fix that as well. This issue does not apply to the command line executable. If you quote file paths with spaces in them on the command line you will have no issues with this. In general, simply avoid spaces in your file paths. It saves lots of headaches. :)