Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Build broken #74

Closed
midzer opened this issue Apr 15, 2017 · 7 comments
Closed

Build broken #74

midzer opened this issue Apr 15, 2017 · 7 comments

Comments

@midzer
Copy link
Contributor

midzer commented Apr 15, 2017

Hi.
Current /dest/ build is broken due required Templater.js, Repository.js, JSONLoader.js and OptionsValidator.js are not included.
This explains the new ultra tiny build size, too :)

Happy easter,
midzer

@christian-fei
Copy link
Owner

Hello, I will look into this. Thanks a lot for reporting :) 🐣

@paulrobertlloyd
Copy link

Just upgraded to the latest version, and seeing the same error. Any news? Thanks!

@daviddarnes
Copy link
Contributor

I don't want to steal away users of this tool, it's done well for me in the past. However I've created an alternative using the fetch() API and a custom json template if anyone is interested? You'll need the fetch.js polyfill from GitHub for older browsers

@paulrobertlloyd
Copy link

@daviddarnes Oooh, nice! I like your implementation a lot, so now using it instead. Thanks!

@daviddarnes
Copy link
Contributor

@paulrobertlloyd you're very welcome! Thanks for the praise! Credit to Wes Bos who screencasted a filter demo using fetch, which inspired me to do this

@davidawad
Copy link

yeah this bug doesn't seem like it's going to be fixed :/

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 5, 2017

@christian-fei: this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants