Update Brainstorm import script (hardcoded fiducials) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was a bit too enthusiastic about what I did before, I realized there were some issues with the script... Maybe you should wait I post a reply on the Brainstorm forum before merging the PR this time :) |
|
@ftadel Yeah, I kinda had the feeling that I was going a bit fast by merging it right away without letting it simmer a bit to see potential problems coming up to the surface... I'll control my impulsive itches this time :) |
|
It's ready to merge now, I'm all done :) |
|
Happy summer! |
|
Alright, if you say so! I'll merge then! Have a nice summer too @ftadel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.