Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing feature tracking for Refitter #878

Merged
merged 1 commit into from
May 5, 2024

Conversation

christianhelle
Copy link
Owner

PR Classification

This pull request involves code refactoring and feature enhancement in the RefitterCodeGenerator.cs file.

PR Summary

The changes in this pull request improve the readability and maintainability of the code, and add logging and JSON serialization/deserialization functionalities.

  • RefitterCodeGenerator.cs: Added Rapicgen.Core.Logging and Newtonsoft.Json namespaces for logging and JSON functionalities.
  • RefitterCodeGenerator.cs: Refactored the creation of RefitGeneratorSettings object for better code readability.
  • RefitterCodeGenerator.cs: Implemented asynchronous creation of RefitGenerator using the settings object.
  • RefitterCodeGenerator.cs: Introduced a DependencyContext object for managing dependencies.
  • RefitterCodeGenerator.cs: Added a call to Succeeded method after code generation, indicating success.
  • RefitterCodeGenerator.cs: Appended an auto-generated code header using GeneratedCode.PrefixAutogeneratedCodeHeader method.

@christianhelle christianhelle self-assigned this May 5, 2024
@christianhelle christianhelle added enhancement New feature or request .NET Pull requests that update .net code labels May 5, 2024
Copy link

sonarcloud bot commented May 5, 2024

@christianhelle christianhelle merged commit c321087 into master May 5, 2024
91 checks passed
@christianhelle christianhelle deleted the missing-refitter-telemetry branch May 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant