Optional OpenAPI Path in CLI arguments #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings file, "Settings.cs" needed a default value for OpenApiPath. This change sets null as the default. It helps avoid potential issues when the value is not explicitly set.
Modified the validation and input handling in GenerateCommand.cs. Initially, only a single OpenAPI path could be accepted. Now, it has been altered to also accommodate a settings file path as input. This change allows users to provide their settings directly in a file rather than passing a long list of command line arguments, improving user experience.
This commit adds a new validation in the GenerateCommand class to avoid conflicts with input sources. After this update, if the user provides both an OpenApiPath and a SettingsFilePath, the application will throw a validation error. This change is meant to ensure that the source of data is clearly defined, either directly or through a settings file.
Modified the pipeline script (smoke-tests.ps1) to use the ForEach-Object instead of the forEach alias when deleting generated C# files. This change was made to make the code more explicit and easier to understand for those unfamiliar with the shorthand syntax.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 39 39
Lines 1255 1255
=======================================
Hits 1235 1235
Misses 6 6
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here gives users the choice to specify the path or URL to the OpenAPI specifications document from either the command line argument or via the settings file specified via
--settings-fileThis implements #149