Use OasReader library for loading OAS documents with external references #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `OpenApiDocumentFactory` class to handle HTTP URLs and YAML files. It adds support for reading OpenAPI documents from HTTP URLs and populating missing required fields. It also includes methods to determine if a path is an HTTP URL and to get the content of a URI as a string. This refactor improves the flexibility and robustness of the `OpenApiDocumentFactory` class.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 98.30% 97.41% -0.89%
==========================================
Files 60 60
Lines 2060 2086 +26
==========================================
+ Hits 2025 2032 +7
- Misses 18 37 +19
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here refactors the way OAS documents are loaded if they have external references.