Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added argument for block transfer to enable/disable CRC Support #240

Merged
merged 2 commits into from
Jun 9, 2021
Merged

added argument for block transfer to enable/disable CRC Support #240

merged 2 commits into from
Jun 9, 2021

Conversation

jnu144
Copy link

@jnu144 jnu144 commented Jun 7, 2021

We had some problems with domain transfers when the SDO Server does not support the CRC_SUPPORTED Flag for the Block Transfer. With this you can disable (optional) the CRC_SUPPORTED Flag when calling open().

Copy link
Owner

@christiansandberg christiansandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add the new argument to the docstrings?

@jnu144
Copy link
Author

jnu144 commented Jun 9, 2021

Ah yes, sorry I forgot

@christiansandberg christiansandberg merged commit ac0d5fd into christiansandberg:master Jun 9, 2021
@jnu144 jnu144 deleted the REQUEST_CRC_SUPPORT branch June 10, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants