Export Eds or Dcf #254
Export Eds or Dcf #254
Conversation
|
Ok, I think that is it. I think i processed all of the feedback :) Thanks for the quick review btw 👍 |
|
I guess this will fix #235 when merged. Should be linked. |
|
Thanks @acolomb I looked before starting, but i didn't see it. |
|
I changed it to a WIP, because i am using it in a project now, and i keep finding missing features. So i'll just add those, and put it back. |
|
Sounds good! There are some camelCase style code left also. |
unsanded
force-pushed
the
feature/writeEDS
branch
from
605ada7
to
06b1454
Compare
The previous one used installed some stuff into usr/local/lib/ next to the intended usr/lib/dist-pakages target. Now using a bdist_wheel package, which is much more clean
Now eds files can also be written. To make the written eds file resemble the read one more, the `DeviceInfo` section is now also read and stored. The `FileInfo` section is also read, but stored privately.
now export_od accepts a filename as destination. If no docType is given, the extension is used as a default. if this fails, eds is still the fallback also better documentation
snake_case in test
unsanded
force-pushed
the
feature/writeEDS
branch
from
06b1454
to
483d4be
Compare
Co-authored-by: Christian Sandberg <christiansandberg@users.noreply.github.com>
|
Cool, thanks for the review :) |
also extended the changes in code style (type annotations)
| class DeviceInformation: | ||
| def __init__(self): | ||
| self.allowed_baudrates = set() | ||
| self.vendor_name:Optional[str] = None |
There was a problem hiding this comment.
Thanks for adding type annotations! However it looks like all attributes are parsed as strings from the EDS so either let them all be strings or convert them during parsing.
There was a problem hiding this comment.
Right, very attentive. Fixed it now.
They used to be all strings copied straight from the eds file. Now they are str, int and bool
I needed this for work, so i wrote it. Also added a unit test.
This fixes #235
supported
not supported
compactSubObjsectionsPs. I improved the deb script slightly. (My previous pull request) So i just included it.
I could rebase it out if we want to be all proper like that :)