Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eds parse factor and description #378

Conversation

marcovannoord
Copy link
Contributor

For my work, i needed to use the Factor and Description, that already seem to have been implemented CANopen. However, they were currently not/never set by an EDS-file.
I added parsing for the Factor and Description, and i have added some unit-tests for them.

@marcovannoord
Copy link
Contributor Author

According to the CanOpen specification, there is room to add these tags:

If not specified otherwise, all sections and entries in this paper are mandatory. In order to support future extensions it is allowed to include additional sections and additional entries inside the sections. Anyhow the Conformance Test Tool will recognise this with warning messages

If not used, or when set to default, they will not be exported, to prevent any changes to current implementations

@unsanded
Copy link
Contributor

I agree that this would be a nice addition, because it feels kind of weird to always use var.raw instead of var.phys. And it would also prevent errors.

@marcovannoord
Copy link
Contributor Author

@christiansandberg What is your opinion about this MR?

@christiansandberg
Copy link
Owner

Sorry for the delay. I think it makes sense to be able to specify it. Not sure what the EDS spec says about custom attributes but it should be OK.

@christiansandberg christiansandberg merged commit 2d5d6d3 into christiansandberg:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants