Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is a blank line between arg-title and reconstruction necessary? #8

Closed
xylomorph opened this issue Apr 12, 2017 · 3 comments
Closed

Comments

@xylomorph
Copy link

Sollte nicht vlt. das

<Argument 1>
(1) First premise (this is is a normal statement 

genauso gehen (behandelt werden) wie

<Argument 1>

(1) First premise (this is is a normal statement 

@christianvoigt
Copy link
Owner

christianvoigt commented Apr 24, 2017

I don't think so. In general we use empty lines to distinguish between block elements. <Argument 1> works here as a heading for the argument and should work similar to other kinds of headings.

A second reason, why we should avoid this: argument titles with and without argument descriptions should behave in the same way. But if there is a description, an empty line is needed to identify the end of the description (as the description may contain single line breaks to make it more readable).

@ggbetz: What do you think?

@ggbetz
Copy link

ggbetz commented Apr 25, 2017

I think it's OK as is. But we should reckon that this might be counter-intuitive to some users. So a medium-term todo would be to make sure that syntax highlighting in the editor points out that in

(1) P1
(2) P2 ...

the premiss-conclusion is not recognised as such (and that the above code is illegal).

Maybe syntax-highlighting of premiss-conclusion reconstructions should check whether there is a blank line before the first premiss and not color the code at all if not.

@christianvoigt
Copy link
Owner

christianvoigt commented Apr 25, 2017

I agree, in some cases the syntax highlighting diverges from the syntax rules of the parser and this is counterintuitive. In part the syntax rules simply changed during development. But in part this is also due to the syntax highlighting using a much simpler parsing method that has some limitations. We should probably discuss these issues in christianvoigt/language-argdown.

Apart from that I think the rule "one empty line after each block element" is intuitive and we should avoid exemptions. As I said we need this rule to allow arbitrary line breaks in statements:

[Statement]: I 
am
a
statement.

Next statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants