Factor out reflectIn(), reflectOut() methods.

christoph2 · Mar 21, 2018 · 9f0e189 · 9f0e189
1 parent 7253748
commit 9f0e189
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/pyxcp/checksum.py b/pyxcp/checksum.py
@@ -133,16 +133,21 @@ def __init__(self, table, initalRemainder, finalXorValue, reflectData, reflectRe
     def __call__(self, frame):
         remainder = self.initalRemainder
         for ch in frame:
-            if self.reflectData:
-                data = (reflect(ch, 8) ^ (remainder >> (self.WIDTH - 8))) & 0xff
-            else:
-                data = (ch ^ (remainder >> (self.WIDTH - 8))) & 0xff
+            data = self.reflectIn(ch, remainder)
             remainder = (self.table[data] ^ (remainder << 8)) & 0xffff
+        return self.reflectOut(remainder)
+
+    def reflectIn(self, ch, remainder):
+        if self.reflectData:
+            return (reflect(ch, 8) ^ (remainder >> (self.WIDTH - 8))) & 0xff
+        else:
+            return (ch ^ (remainder >> (self.WIDTH - 8))) & 0xff
+
+    def reflectOut(self, remainder):
         if self.reflectRemainder:
-            result =  (reflect(remainder, 16) ^ self.finalXorValue)
+            return reflect(remainder, 16) ^ self.finalXorValue
         else:
-            result = remainder ^ self.finalXorValue
-        return result
+            return remainder ^ self.finalXorValue
 
 
 """