fix: ignore directory with no package.json with warning

christophehurpeau · Jan 29, 2023 · 76cdddf · 76cdddf
1 parent 6b4e0f3
commit 76cdddf
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 9 deletions.
diff --git a/dist/definitions/check-package-with-workspaces.d.ts.map b/dist/definitions/check-package-with-workspaces.d.ts.map
diff --git a/dist/definitions/utils/__mocks__/createReportError.d.ts b/dist/definitions/utils/__mocks__/createReportError.d.ts
@@ -1,4 +1,4 @@
 /// <reference types="jest" />
-export declare const mockReportError: jest.Mock<any, any, any>;
-export declare const createReportError: jest.Mock<any, any, any>;
+export declare const mockReportError: jest.Mock<any, any>;
+export declare const createReportError: jest.Mock<any, any>;
 //# sourceMappingURL=createReportError.d.ts.map
diff --git a/dist/definitions/utils/__mocks__/createReportError.d.ts.map b/dist/definitions/utils/__mocks__/createReportError.d.ts.map
diff --git a/dist/index-node16.mjs b/dist/index-node16.mjs
@@ -866,8 +866,10 @@ function createCheckPackageWithWorkspaces(createCheckPackageOptions = {}) {
         cwd: pkgDirname
       });
       match.forEach(pathMatch => {
-        const stat = fs.statSync(pathMatch);
-        if (!stat.isDirectory()) return;
+        if (!fs.existsSync(path.join(pathMatch, 'package.json'))) {
+          console.log(`Ignored potential directory, no package.json found: ${pathMatch}`);
+          return;
+        }
         const subPkgDirectoryPath = path.relative(process.cwd(), pathMatch);
         workspacePackagesPaths.push(subPkgDirectoryPath);
       });

diff --git a/dist/index-node16.mjs.map b/dist/index-node16.mjs.map
diff --git a/src/check-package-with-workspaces.ts b/src/check-package-with-workspaces.ts
@@ -93,8 +93,12 @@ export function createCheckPackageWithWorkspaces(
     pkgWorkspaces.forEach((pattern) => {
       const match = glob.sync(pattern, { cwd: pkgDirname });
       match.forEach((pathMatch) => {
-        const stat = fs.statSync(pathMatch);
-        if (!stat.isDirectory()) return;
+        if (!fs.existsSync(path.join(pathMatch, 'package.json'))) {
+          console.log(
+            `Ignored potential directory, no package.json found: ${pathMatch}`,
+          );
+          return;
+        }
         const subPkgDirectoryPath = path.relative(process.cwd(), pathMatch);
         workspacePackagesPaths.push(subPkgDirectoryPath);
       });