feat: check duplicates from previously checked packages in monorepo

christophehurpeau · Jul 7, 2022 · eec2e71 · eec2e71
1 parent 4d260e4
commit eec2e71
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 4 deletions.
diff --git a/dist/check-package-with-workspaces.d.ts.map b/dist/check-package-with-workspaces.d.ts.map
diff --git a/dist/index-node14.cjs.js b/dist/index-node14.cjs.js
diff --git a/dist/index-node14.cjs.js.map b/dist/index-node14.cjs.js.map
diff --git a/src/check-package-with-workspaces.ts b/src/check-package-with-workspaces.ts
@@ -156,6 +156,7 @@ export function createCheckPackageWithWorkspaces(
           monorepoDirectDuplicateDependenciesOnlyWarnsFor,
         );
 
+      const previousCheckedWorkspaces = new Map<string, CheckPackageApi>();
       checksWorkspaces.forEach((checkSubPackage, id) => {
         const isPackageALibrary = isLibrary(id);
         checkSubPackage.checkRecommended({
@@ -183,6 +184,7 @@ export function createCheckPackageWithWorkspaces(
           'Monorepo Direct Duplicate Dependencies',
           checkSubPackage.pkgPathName,
         );
+        // Root
         checkDuplicateDependencies(
           reportMonorepoDDDError,
           checkSubPackage.pkg,
@@ -193,6 +195,41 @@ export function createCheckPackageWithWorkspaces(
             checkSubPackage.pkg.name,
           ),
         );
+        // previous packages
+        previousCheckedWorkspaces.forEach((previousCheckSubPackage) => {
+          checkDuplicateDependencies(
+            reportMonorepoDDDError,
+            checkSubPackage.pkg,
+            'devDependencies',
+            ['dependencies', 'devDependencies'],
+            previousCheckSubPackage.pkg,
+            monorepoDirectDuplicateDependenciesOnlyWarnsForCheck.createFor(
+              checkSubPackage.pkg.name,
+            ),
+          );
+          checkDuplicateDependencies(
+            reportMonorepoDDDError,
+            checkSubPackage.pkg,
+            'dependencies',
+            ['dependencies', 'devDependencies'],
+            previousCheckSubPackage.pkg,
+            monorepoDirectDuplicateDependenciesOnlyWarnsForCheck.createFor(
+              checkSubPackage.pkg.name,
+            ),
+          );
+          checkDuplicateDependencies(
+            reportMonorepoDDDError,
+            checkSubPackage.pkg,
+            'peerDependencies',
+            ['peerDependencies'],
+            previousCheckSubPackage.pkg,
+            monorepoDirectDuplicateDependenciesOnlyWarnsForCheck.createFor(
+              checkSubPackage.pkg.name,
+            ),
+          );
+        });
+
+        previousCheckedWorkspaces.set(id, checkSubPackage);
       });
       reportNotWarnedForMapping(
         createReportError(