Skip to content

Commit

Permalink
feat: warn dot in key add key and diplayname
Browse files Browse the repository at this point in the history
  • Loading branch information
christophehurpeau committed Mar 10, 2018
1 parent c9f9612 commit 7a5967c
Show file tree
Hide file tree
Showing 21 changed files with 43 additions and 21 deletions.
4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-browsers-dev/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-browsers-dev/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-browsers/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-browsers/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-node6-dev/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-node6-dev/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-node6/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-node6/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-older-node-dev/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-older-node/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-older-node/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-webpack-dev/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-webpack-dev/index.js.map

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/lib-webpack/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nightingale-logger/lib-webpack/index.js.map

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion packages/nightingale-logger/src/index.js
Expand Up @@ -43,7 +43,9 @@ export default class Logger {
constructor(key: string, displayName: ?string) {
this.key = key.replace('.', ':');
this.displayName = displayName;
if (key.includes('.')) this.warn('nightingale: `.` in key is deprecated, replace with `:`');
if (key.includes('.')) {
this.warn('nightingale: `.` in key is deprecated, replace with `:`', { key, displayName });
}
}

/** @private */
Expand Down

0 comments on commit 7a5967c

Please sign in to comment.