feat: add support for node 4

christophehurpeau · Mar 10, 2018 · 969b2cb · 969b2cb
1 parent 48f4c2d
commit 969b2cb
Show file tree

Hide file tree

Showing 10 changed files with 53 additions and 15 deletions.
diff --git a/packages/nightingale-json-formatter/.pob.json b/packages/nightingale-json-formatter/.pob.json
@@ -2,6 +2,7 @@
   "envs": [
     "node6",
     "node7",
+    "older-node",
     "module-modern-browsers",
     "module",
     "module-node7"

diff --git a/packages/nightingale-json-formatter/.travis.yml b/packages/nightingale-json-formatter/.travis.yml
@@ -2,6 +2,7 @@ language: node_js
 node_js:
   - node
   - "6"
+  - "4"
 
 cache:
   yarn: true

diff --git a/packages/nightingale-json-formatter/index.js b/packages/nightingale-json-formatter/index.js
@@ -9,4 +9,4 @@ if (nodeVersionMajor > 7 || (nodeVersionMajor === 7 && nodeVersionMinor >= 6))
 if (nodeVersionMajor > 6 || (nodeVersionMajor === 6 && nodeVersionMinor >= 5))
   return module.exports = require('./lib-node6' + (production ? '' : '-dev') + '/index');
 /* istanbul ignore next */
-throw new Error('Node version not supported: ' + nodeVersion + ' (' + process.versions.node + ').');
+return module.exports = require('./lib-older-node' + (production ? '' : '-dev') + '/index');
diff --git a/packages/nightingale-json-formatter/lib-older-node-dev/index.js b/packages/nightingale-json-formatter/lib-older-node-dev/index.js
diff --git a/packages/nightingale-json-formatter/lib-older-node-dev/index.js.map b/packages/nightingale-json-formatter/lib-older-node-dev/index.js.map
diff --git a/packages/nightingale-json-formatter/lib-older-node/index.js b/packages/nightingale-json-formatter/lib-older-node/index.js
diff --git a/packages/nightingale-json-formatter/lib-older-node/index.js.map b/packages/nightingale-json-formatter/lib-older-node/index.js.map
diff --git a/packages/nightingale-json-formatter/package.json b/packages/nightingale-json-formatter/package.json
@@ -10,9 +10,6 @@
   "license": "ISC",
   "repository": "git@github.com:nightingalejs/nightingale-json-formatter.git",
   "homepage": "https://github.com/nightingalejs/nightingale",
-  "engines": {
-    "node": ">=6.5.0"
-  },
   "main": "./index.js",
   "module": "./lib-module/index.js",
   "module-dev": "./lib-module-dev/index.js",
@@ -43,7 +40,7 @@
     "babel-preset-latest-node": "^0.2.2",
     "babel-preset-modern-browsers": "^9.0.2",
     "eslint": "^3.18.0",
-    "eslint-config-airbnb-base": "^11.1.1",
+    "eslint-config-airbnb-base": "^11.1.2",
     "eslint-config-pob": "^11.1.0",
     "eslint-plugin-babel": "^4.1.1",
     "eslint-plugin-import": "^2.2.0",

diff --git a/packages/nightingale-json-formatter/test/.eslintrc.js b/packages/nightingale-json-formatter/test/.eslintrc.js
@@ -2,11 +2,6 @@ exports.rules = {
   "import/no-extraneous-dependencies": [2, {"devDependencies": true}]
 };
 
-exports.globals = {
-  suite: true,
-  test: true,
-  suiteSetup: true,
-  suiteTeardown: true,
-  setup: true,
-  teardown: true,
+exports.env = {
+  mocha: true,
 };
diff --git a/packages/nightingale-json-formatter/yarn.lock b/packages/nightingale-json-formatter/yarn.lock
@@ -1422,9 +1422,9 @@ escope@^3.6.0:
     esrecurse "^4.1.0"
     estraverse "^4.1.1"
 
-eslint-config-airbnb-base@^11.1.1:
-  version "11.1.1"
-  resolved "https://registry.yarnpkg.com/eslint-config-airbnb-base/-/eslint-config-airbnb-base-11.1.1.tgz#61e9e89e4eb89f474f6913ac817be9fbb59063e0"
+eslint-config-airbnb-base@^11.1.2:
+  version "11.1.2"
+  resolved "https://registry.yarnpkg.com/eslint-config-airbnb-base/-/eslint-config-airbnb-base-11.1.2.tgz#259209a7678bf693e31cbe8f953f206b6aa7ccc3"
 
 eslint-config-pob@^11.1.0:
   version "11.1.0"