fix: logger key warning

christophehurpeau · Mar 10, 2018 · a8097d7 · a8097d7
1 parent 4b27d4e
commit a8097d7
Show file tree

Hide file tree

Showing 21 changed files with 54 additions and 43 deletions.
diff --git a/packages/nightingale-logger/lib-browsers-dev/index.js b/packages/nightingale-logger/lib-browsers-dev/index.js
diff --git a/packages/nightingale-logger/lib-browsers-dev/index.js.map b/packages/nightingale-logger/lib-browsers-dev/index.js.map
diff --git a/packages/nightingale-logger/lib-browsers/index.js b/packages/nightingale-logger/lib-browsers/index.js
diff --git a/packages/nightingale-logger/lib-browsers/index.js.map b/packages/nightingale-logger/lib-browsers/index.js.map
diff --git a/packages/nightingale-logger/lib-node6-dev/index.js b/packages/nightingale-logger/lib-node6-dev/index.js
diff --git a/packages/nightingale-logger/lib-node6-dev/index.js.map b/packages/nightingale-logger/lib-node6-dev/index.js.map
diff --git a/packages/nightingale-logger/lib-node6/index.js b/packages/nightingale-logger/lib-node6/index.js
diff --git a/packages/nightingale-logger/lib-node6/index.js.map b/packages/nightingale-logger/lib-node6/index.js.map
diff --git a/packages/nightingale-logger/lib-older-node-dev/index.js b/packages/nightingale-logger/lib-older-node-dev/index.js
diff --git a/packages/nightingale-logger/lib-older-node-dev/index.js.map b/packages/nightingale-logger/lib-older-node-dev/index.js.map
diff --git a/packages/nightingale-logger/lib-older-node/index.js b/packages/nightingale-logger/lib-older-node/index.js
diff --git a/packages/nightingale-logger/lib-older-node/index.js.map b/packages/nightingale-logger/lib-older-node/index.js.map
diff --git a/packages/nightingale-logger/lib-webpack-dev/index.js b/packages/nightingale-logger/lib-webpack-dev/index.js
diff --git a/packages/nightingale-logger/lib-webpack-dev/index.js.map b/packages/nightingale-logger/lib-webpack-dev/index.js.map
diff --git a/packages/nightingale-logger/lib-webpack-modern-browsers-dev/index.js b/packages/nightingale-logger/lib-webpack-modern-browsers-dev/index.js
diff --git a/packages/nightingale-logger/lib-webpack-modern-browsers-dev/index.js.map b/packages/nightingale-logger/lib-webpack-modern-browsers-dev/index.js.map
diff --git a/packages/nightingale-logger/lib-webpack-modern-browsers/index.js b/packages/nightingale-logger/lib-webpack-modern-browsers/index.js
diff --git a/packages/nightingale-logger/lib-webpack-modern-browsers/index.js.map b/packages/nightingale-logger/lib-webpack-modern-browsers/index.js.map
diff --git a/packages/nightingale-logger/lib-webpack/index.js b/packages/nightingale-logger/lib-webpack/index.js
diff --git a/packages/nightingale-logger/lib-webpack/index.js.map b/packages/nightingale-logger/lib-webpack/index.js.map
diff --git a/packages/nightingale-logger/src/index.js b/packages/nightingale-logger/src/index.js
@@ -67,12 +67,13 @@ export default class Logger {
    * @param {string} [displayName]
    */
   constructor(key: string, displayName: ?string) {
+    this.key = key;
+    this.displayName = displayName;
+
     if (key.includes('.')) {
       this.warn('nightingale: `.` in key is deprecated, replace with `:`', { key, displayName });
-      key = key.replace(/\./g, ':');
+      this.key = key.replace(/\./g, ':');
     }
-    this.key = key;
-    this.displayName = displayName;
   }
 
   /** @private */