fix: catch 404 remove non existing label

christophehurpeau · Aug 30, 2019 · 255aecf · 255aecf
1 parent 19a9df8
commit 255aecf
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 16 deletions.
diff --git a/dist/index-node10-dev.cjs.js b/dist/index-node10-dev.cjs.js
diff --git a/dist/index-node10-dev.cjs.js.map b/dist/index-node10-dev.cjs.js.map
diff --git a/dist/index-node10.cjs.js b/dist/index-node10.cjs.js
diff --git a/dist/index-node10.cjs.js.map b/dist/index-node10.cjs.js.map
diff --git a/src/pr-handlers/actions/updateReviewStatus.ts b/src/pr-handlers/actions/updateReviewStatus.ts
@@ -115,12 +115,18 @@ export const updateReviewStatus = async <
 
       if (toDelete.size !== 0) {
         for (const toDeleteName of [...toDeleteNames]) {
-          const result = await context.github.issues.removeLabel(
-            context.issue({
-              name: toDeleteName,
-            }),
-          );
-          prLabels = result.data;
+          try {
+            const result = await context.github.issues.removeLabel(
+              context.issue({
+                name: toDeleteName,
+              }),
+            );
+            prLabels = result.data;
+          } catch (err) {
+            context.log.warn('error removing label', {
+              err: err && err.message,
+            });
+          }
         }
       }
     } else {