feat: move option lintPullRequestTitleWithConventionalCommit out of e…

…xperimental
christophehurpeau · Nov 10, 2023 · 28db2b2 · 28db2b2
1 parent 3d0fb3e
commit 28db2b2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/accountConfigs/christophehurpeau.ts b/src/accountConfigs/christophehurpeau.ts
@@ -9,8 +9,8 @@ const config: Config<never> = {
     autoMergeWithSkipCi: false,
     deleteAfterMerge: true,
   },
+  lintPullRequestTitleWithConventionalCommit: true,
   experimentalFeatures: {
-    lintPullRequestTitleWithConventionalCommit: true,
     conventionalCommitBangBreakingChange: true,
     betterSlackify: true,
   },

diff --git a/src/accountConfigs/defaultConfig.ts b/src/accountConfigs/defaultConfig.ts
@@ -4,6 +4,7 @@ import type { Config } from './types';
 const config: Config<never> = {
   autoAssignToCreator: true,
   trimTitle: true,
+  lintPullRequestTitleWithConventionalCommit: false,
   requiresReviewRequest: false,
   prDefaultOptions: {
     autoMerge: false,

diff --git a/src/accountConfigs/types.ts b/src/accountConfigs/types.ts
@@ -62,7 +62,6 @@ export interface LabelsConfig {
 }
 
 interface ExperimentalFeatures {
-  lintPullRequestTitleWithConventionalCommit?: true;
   conventionalCommitBangBreakingChange?: true;
   betterSlackify?: true;
 }
@@ -75,6 +74,7 @@ interface WarnOnForcePushAfterReviewStarted {
 export interface Config<TeamNames extends string> {
   autoAssignToCreator?: boolean;
   trimTitle?: boolean;
+  lintPullRequestTitleWithConventionalCommit?: boolean;
   ignoreRepoPattern?: string;
   requiresReviewRequest?: boolean;
   autoMergeRenovateWithSkipCi?: boolean;

diff --git a/src/events/pr-handlers/actions/editOpenedPR.ts b/src/events/pr-handlers/actions/editOpenedPR.ts
@@ -90,10 +90,7 @@ export const editOpenedPR = async <
   const statuses: ReviewflowStatus[] = [];
   let errorStatus: StatusInfo | undefined;
 
-  if (
-    repoContext.config.experimentalFeatures
-      ?.lintPullRequestTitleWithConventionalCommit
-  ) {
+  if (repoContext.config.lintPullRequestTitleWithConventionalCommit) {
     try {
       const lintOutcome = await lintCommitMessage(title);
       if (!lintOutcome.valid) {