feat: reenable sender check in dissmissed review

christophehurpeau · Aug 22, 2018 · 2a88c1f · 2a88c1f
1 parent 819d88b
commit 2a88c1f
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -210,7 +210,7 @@ module.exports = (app) => {
   app.on('pull_request_review.dismissed', async (context) => {
     const repoContext = await obtainRepoContext(context);
     if (!repoContext) return;
-    // const sender = context.payload.sender;
+    const sender = context.payload.sender;
     const pr = context.payload.pull_request;
     const reviewer = context.payload.review.user;
 
@@ -243,23 +243,25 @@ module.exports = (app) => {
       })
     );
 
-    // if (sender.login === reviewer.login) {
-    //   repoContext.slack.postMessage(
-    //     pr.user.login,
-    //     `${repoContext.slack.mention(reviewer.login)} dismissed his review on ${pr.html_url}`
-    //   );
-    // } else {
-    //   repoContext.slack.postMessage(
-    //     reviewer.login,
-    //     `${repoContext.slack.mention(sender.login)} dismissed your review on ${
-    //       pr.html_url
-    //     }, he requests a new one !`
-    //   );
-    // }
+    if (sender.login === reviewer.login) {
+      repoContext.slack.postMessage(
+        pr.user.login,
+        `${repoContext.slack.mention(reviewer.login)} dismissed his review on ${
+          pr.html_url
+        }`
+      );
+    } else {
+      repoContext.slack.postMessage(
+        reviewer.login,
+        `${repoContext.slack.mention(sender.login)} dismissed your review on ${
+          pr.html_url
+        }, he requests a new one !`
+      );
+    }
 
-    repoContext.slack.postMessage(
-      reviewer.login,
-      `Your review was dismissed on ${pr.html_url}`
-    );
+    // repoContext.slack.postMessage(
+    //   reviewer.login,
+    //   `Your review was dismissed on ${pr.html_url}`
+    // );
   });
 };