Skip to content

Commit

Permalink
fix: review_requested remove label needsReview when REQUEST_CHANGES w…
Browse files Browse the repository at this point in the history
…as done by the newly requested reviewer
  • Loading branch information
christophehurpeau committed Sep 12, 2018
1 parent 656a5c7 commit 46c0f3c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/index.js
Expand Up @@ -56,7 +56,9 @@ module.exports = (app) => {
const hasRequestChangesInReviews = reviews.some(
(review) =>
repoContext.getReviewerGroup(review.user.login) === reviewerGroup &&
review.state === 'REQUEST_CHANGES'
review.state === 'REQUEST_CHANGES' &&
// In case this is a rerequest for review
review.user.login !== reviewer.login
);

if (!hasRequestChangesInReviews) {
Expand Down

0 comments on commit 46c0f3c

Please sign in to comment.