fix: review status check when approved and still has needsReview

lib/context/repoContext.js

@@ -14,6 +14,11 @@ const initRepoContext = async (context, config) => {
     .filter(Boolean)
     .map((name) => labels[name].id);
 
+  const approvedReviewLabelIds = Object.keys(config.labels.review)
+    .map((key) => config.labels.review[key].approved)
+    .filter(Boolean)
+    .map((name) => labels[name].id);
+
   const addStatusCheck = (context, statusInfo) => {
     const pr = context.payload.pull_request;
 
@@ -45,29 +50,26 @@ const initRepoContext = async (context, config) => {
 
   // const updateStatusCheck = (context, reviewGroup, statusInfo) => {};
 
-  const isAllReviewsDone = (labels) =>
-    !labels.some((label) => needsReviewLabelIds.includes(label.id));
+  const hasNeedsReview = labels.some((label) =>
+    needsReviewLabelIds.includes(label.id)
+  );
+  const hasApprovesReview = labels.some((label) =>
+    approvedReviewLabelIds.includes(label.id)
+  );
 
   const updateStatusCheckFromLabels = (
     context,
     labels = context.payload.pull_request.labels || []
   ) => {
-    if (isAllReviewsDone(labels)) {
-      return createDoneStatusCheck(context);
-    }
-  };
-
-  const createStatusCheckFromLabels = (context) => {
-    const labels = context.payload.pull_request.labels || [];
-    if (isAllReviewsDone(labels)) {
-      return createDoneStatusCheck(context);
-    } else {
+    if (hasNeedsReview(labels)) {
       return createInProgressStatusCheck(context);
+    } else if (hasApprovesReview(labels)) {
+      return createDoneStatusCheck(context);
     }
   };
 
   return Object.assign(repoContext, {
-    updateStatusCheckFromLabels: createStatusCheckFromLabels,
+    updateStatusCheckFromLabels,
 
     updateReviewStatus: async (
       context,
@@ -133,7 +135,7 @@ const initRepoContext = async (context, config) => {
     addStatusCheckToLatestCommit: (context) =>
       // old and new sha
       // const { before, after } = context.payload;
-      createStatusCheckFromLabels(context),
+      updateStatusCheckFromLabels(context),
   });
 };