fix: call to getGithubTeamsForMember when not an org

christophehurpeau · Jan 21, 2023 · 5403fb0 · 5403fb0
1 parent ab21e7f
commit 5403fb0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/context/accountContext.ts b/src/context/accountContext.ts
@@ -216,7 +216,7 @@ const initAccountContext = async <
     getGithubTeamsForMember: async (memberId): Promise<OrgMember['teams']> => {
       if (accountInfo.type !== 'Organization') {
         throw new Error(
-          `Invalid account type "${accountInfo.type}" for getTeamsForMember`,
+          `Invalid account type "${accountInfo.type}" for getGithubTeamsForMember`,
         );
       }
       const orgMember = await appContext.mongoStores.orgMembers.findOne({

diff --git a/src/events/pr-handlers/reviewSubmitted.ts b/src/events/pr-handlers/reviewSubmitted.ts
@@ -74,7 +74,9 @@ export default function reviewSubmitted(
       const [{ reviewers, reviewStates }, reviewerGithubTeams] =
         await Promise.all([
           getReviewersAndReviewStates(context, repoContext),
-          repoContext.getGithubTeamsForMember(reviewer.id),
+          repoContext.accountEmbed.type !== 'Organization'
+            ? []
+            : repoContext.getGithubTeamsForMember(reviewer.id),
         ]);
       const { owner, assignees, followers } =
         getRolesFromPullRequestAndReviewers(pullRequest, reviewers, {