Skip to content

Commit

Permalink
fix: release lock when pr is already merged
Browse files Browse the repository at this point in the history
  • Loading branch information
christophehurpeau committed Apr 14, 2019
1 parent 9f16948 commit 68b91df
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 8 deletions.
8 changes: 6 additions & 2 deletions dist/index-node10-dev.cjs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index-node10-dev.cjs.js.map

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions dist/index-node10.cjs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index-node10.cjs.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/pr-handlers/actions/autoMergeIfPossible.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion src/pr-handlers/actions/autoMergeIfPossible.ts
Expand Up @@ -44,12 +44,19 @@ export const autoMergeIfPossible = async (
}

if (pr.merged) {
repoContext.removeMergeLocked(context, pr.number);
context.log.info(`automerge not possible: already merged pr ${pr.id}`);
return false;
}

context.log.info(
`automerge?: ${pr.id}, mergeable=${pr.mergeable} state=${
pr.mergeable_state
}`,
);
if (!pr.mergeable) {
if (pr.mergeable_state === undefined) {
if (!pr.mergeable_state) {
context.log.info(`automerge not possible: rescheduling ${pr.id}`);
// GitHub is determining whether the pull request is mergeable
repoContext.reschedule(context, String(pr.id), pr.number);
return false;
Expand Down

0 comments on commit 68b91df

Please sign in to comment.