fix: fix 404 when remove label that is not on the pr

christophehurpeau · Jan 23, 2023 · 8586e76 · 8586e76
1 parent 0eb7c0b
commit 8586e76
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/events/pr-handlers/actions/utils/syncLabel.ts b/src/events/pr-handlers/actions/utils/syncLabel.ts
@@ -122,7 +122,16 @@ export async function syncLabels<EventName extends EmitterWebhookEventName>(
 
   if (labelsToRemove.length > 0) {
     for (const label of labelsToRemove) {
-      updatedLabels = await removeLabel(context, pullRequest, label);
+      try {
+        updatedLabels = await removeLabel(context, pullRequest, label);
+      } catch (err) {
+        // can happen on old prs without all labels reviewflow expects
+        if ((err as any).status === 404) {
+          // do nothing, continue
+        } else {
+          throw err;
+        }
+      }
     }
   }
   if (labelsToAdd.length > 0) {