feat: protect labels

christophehurpeau · Apr 3, 2019 · a0b24e1 · a0b24e1
1 parent 7ff2078
commit a0b24e1
Show file tree

Hide file tree

Showing 12 changed files with 66 additions and 17 deletions.
diff --git a/dist/context/repoContext.d.ts b/dist/context/repoContext.d.ts
@@ -3,6 +3,7 @@ import { LabelResponse, Labels } from './initRepoLabels';
 import { TeamContext } from './teamContext';
 interface RepoContextWithoutTeamContext<GroupNames extends string> {
     labels: Labels;
+    protectedLabelIds: LabelResponse['id'][];
     hasNeedsReview: (labels: LabelResponse[]) => boolean;
     hasRequestedReview: (labels: LabelResponse[]) => boolean;
     hasChangesRequestedReview: (labels: LabelResponse[]) => boolean;

diff --git a/dist/context/repoContext.d.ts.map b/dist/context/repoContext.d.ts.map
diff --git a/dist/index-node10-dev.cjs.js b/dist/index-node10-dev.cjs.js
diff --git a/dist/index-node10-dev.cjs.js.map b/dist/index-node10-dev.cjs.js.map
diff --git a/dist/index-node10.cjs.js b/dist/index-node10.cjs.js
diff --git a/dist/index-node10.cjs.js.map b/dist/index-node10.cjs.js.map
diff --git a/dist/pr-handlers/checkrunCompleted.d.ts.map b/dist/pr-handlers/checkrunCompleted.d.ts.map
diff --git a/dist/pr-handlers/labelsChanged.d.ts.map b/dist/pr-handlers/labelsChanged.d.ts.map
diff --git a/src/context/initRepoLabels.ts b/src/context/initRepoLabels.ts
@@ -57,7 +57,7 @@ export const initRepoLabels = async <GroupNames extends string>(
     } else if (
       existingLabel.name !== labelConfig.name ||
       existingLabel.color !== labelColor // ||
-      // TODO: description is always undefined
+      // TODO: description is never updated
       // existingLabel.description !== description
     ) {
       context.log.info('Needs to update label', {

diff --git a/src/context/repoContext.ts b/src/context/repoContext.ts
@@ -8,6 +8,7 @@ import { obtainTeamContext, TeamContext } from './teamContext';
 
 interface RepoContextWithoutTeamContext<GroupNames extends string> {
   labels: Labels;
+  protectedLabelIds: LabelResponse['id'][];
 
   hasNeedsReview: (labels: LabelResponse[]) => boolean;
   hasRequestedReview: (labels: LabelResponse[]) => boolean;
@@ -89,6 +90,11 @@ async function initRepoContext<GroupNames extends string>(
 
   return Object.assign(repoContext, {
     labels,
+    protectedLabelIds: [
+      ...requestedReviewLabelIds,
+      ...changesRequestedLabelIds,
+      ...approvedReviewLabelIds,
+    ],
     hasNeedsReview,
     hasRequestedReview,
     hasChangesRequestedReview,

diff --git a/src/pr-handlers/checkrunCompleted.ts b/src/pr-handlers/checkrunCompleted.ts
@@ -8,10 +8,6 @@ export default (app: Application) => {
     createHandlerPullRequestsChange(
       (context) => context.payload.check_run.pull_requests,
       async (context, repoContext) => {
-        console.log(
-          'check_run.completed',
-          context.payload.check_run.pull_requests,
-        );
         await Promise.all(
           context.payload.check_run.pull_requests.map((pr) =>
             context.github.pulls

diff --git a/src/pr-handlers/labelsChanged.ts b/src/pr-handlers/labelsChanged.ts
@@ -11,11 +11,25 @@ export default (app: Application) => {
       if (sender.type === 'Bot') return;
 
       await handlerPullRequestChange(context, async (repoContext) => {
+        const label = context.payload.label;
+        if (repoContext.protectedLabelIds.includes(label.id)) {
+          if (context.payload.action === 'labeled') {
+            await context.github.issues.removeLabel(
+              context.issue({ name: label.name }),
+            );
+          } else {
+            await context.github.issues.addLabels(
+              context.issue({ labels: [label.name] }),
+            );
+          }
+          return;
+        }
+
         await updateStatusCheckFromLabels(context, repoContext);
 
         if (
           context.payload.action === 'labeled' &&
-          context.payload.label.id ===
+          label.id ===
             (repoContext.labels['merge/automerge'] &&
               repoContext.labels['merge/automerge'].id)
         ) {