Add rule for blank lines after multiline assignment #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eksperimental
requested changes
Mar 8, 2017
README.md
Outdated
| * <a name="add-blank-line-after-multiline-assignment"></a> | ||
| Add a blank line after a multiline assignment as a | ||
| visual cue that the assignment is 'over' | ||
| <sup>[[link](#add-blank-line-after-multiline-assignment)]</sup> |
There was a problem hiding this comment.
missing ending period.
README.md
Outdated
| |> String.strip | ||
|
|
||
| another_string <> some_string | ||
|
|
There was a problem hiding this comment.
break the examples into two different examples, by closing it with "" and reopening it with "elixir"
corroded
force-pushed
the
blank_line_after_multiline_assignment
branch
from
e32a881
to
561a13d
Compare
|
@eksperimental thanks for reviewing! Addressed the comments 👍 |
eksperimental
approved these changes
Mar 8, 2017
|
Great! |
|
thank you @corroded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #60 . I made the examples as simple as I could think of and separated the examples as @eksperimental suggested.