-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js embedded Studio: Global CSS cannot be imported from within node_modules. #32
Comments
Ok so apparently this is the expected behavior from Next.js when global CSS files are being imported (even in external packages). There's an RFC regarding it here. To sum up the discussion, it seems that users complain about this and that they have opted out of this behavior in Next.js 13 with App Router. So for users that use sanity-plugin-icon-picker in a Next.js embedded Sanity Studio that's not using Next.js App Router this is a problem. I've looked into several workarounds and found these two packages: How ever, none of these seem to do the trick for me when testing with a Next.js (13.4.3) embedded Sanity Studio. So how can we work around this? The problem is this css import which is a workaround for this F7 issue. Potential solutions:
|
I tested this again just now and I realized that everything works just fine when importing the F7 icon components now. I must've made a mistake while testing the 5.0.5 version the first time. I'll implement a fix for this now. |
The reason for that error is probably because I needed to implement an ugly fix where i import a global css file for F7 in order to render out the icons properly due to this issue: framework7io/framework7-icons#48
The text was updated successfully, but these errors were encountered: