Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make diagonalNetwork and radialNetwork responsive (sort-of) #83

Conversation

timelyportfolio
Copy link
Collaborator

This pull is a little more intrusive on the current behavior of diagonalNetwork and radialNetwork, but I think it wisely lets the viewBox attribute of SVG handle sizing and resizing. It seems the resize method already is a little broken, so I don't think this causes any more damage. Using this approach also insures that the diagram fits within the htmlwidget container div, so a R user does not need to fiddle with margins unless desired.

At a minimum, I think this should exist as an argument to toggle on or off, but I'm very comfortable making this the default behavior especially given @christophergandrud focus on simplicity.
networkd3 responsive

@christophergandrud
Copy link
Owner

I really like it and don't think there is any need in principle to dedicate an argument to this.

One issue I just spotted and haven't had a chance to look into: If you knit the gh-pages .Rmd file you will see that it produces strange and undesirable behaviour.

@timelyportfolio
Copy link
Collaborator Author

Thanks so much for the feedback and bug discovery. I'll work out the kinks and hopefully have a working pull momentarily.

@timelyportfolio
Copy link
Collaborator Author

I believe I have worked out the kinks in 1a9d8f5. @christophergandrud, do you mind verifying?

@christophergandrud
Copy link
Owner

Nice, merging into master now.

@christophergandrud christophergandrud merged commit 165c03f into christophergandrud:master Oct 1, 2015
@timelyportfolio
Copy link
Collaborator Author

oh great, what else for CRAN? anything you would like to implement? I'll keep going through the existing pulls.

@christophergandrud
Copy link
Owner

Generally, I'm a believer in relatively incremental CRAN updates to mimimise the risk of unanticipated code breaks at any given update. So I'm fine.

But if you think there is an important pull to merge, then lets do that.

@timelyportfolio
Copy link
Collaborator Author

#85 reminded me that the gh-pages site will demo the newest and greatest, which argues for a quicker CRAN submit. I am ready when you are.

@christophergandrud
Copy link
Owner

I'm also ready if you are. I'll make compile it now and send it up to CRAN.

@christophergandrud
Copy link
Owner

. . . submitted v0.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants