Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs generation breaks with custom module name generation when using typedoc v0.19.2 #548

Closed
anmolarora1 opened this issue Oct 22, 2020 · 1 comment

Comments

@anmolarora1
Copy link

Screenshot 2020-10-22 at 2 58 44 PM

The typedoc generation fails with v0.19.2 when a custom module name generation mapper is used because it's assumed that the rootFileNames would always be a non-empty array.

Screenshot 2020-10-22 at 2 44 01 PM

There's no such expectation in the method definition in though - check getRootFileNames method (taken from Typescript)

As a result, the function breaks unexpectedly when there are no rootFileNames

The solution might be fiddlier than it seems, but adding an empty array check on this line prevents unexpected errors for now.

@christopherthielen
Copy link
Owner

The root path auto-detection code assumed you used files in your tsconfig.json and didn't account for includes syntax.
This fix should fall back to using the current directory instead when includes is used.

Released in version 4.0.4

@anmolarora1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants