fix(sticky): allow empty options parameter to transitionTo()

closes #285
christopherthielen · Jan 25, 2016 · 1d8b1b6 · 1d8b1b6
1 parent 83866b5
commit 1d8b1b6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/stickyProvider.js b/src/stickyProvider.js
@@ -132,7 +132,7 @@ function $StickyStateProvider($stateProvider, uirextras_coreProvider) {
         var toParams = transition.toParams;
         var keep = 0, state = toPath[keep];
 
-        if (transition.options.inherit) {
+        if (transition.options && transition.options.inherit) {
           toParams = transition.toParams =
               inheritParams($stateParams, toParams || {}, $state.$current, transition.toState);
         }
@@ -206,7 +206,7 @@ function $StickyStateProvider($stateProvider, uirextras_coreProvider) {
           //   enter: full resolve, no special logic
           //   reactivate: use previous locals
           //   reload: like 'enter', except exit the inactive state before entering it.
-          var reloaded = !!transition.options.reload;
+          var reloaded = transition.options && !!transition.options.reload;
           enteringTypes = treeChanges.entering.map(function(state) {
             var type = getEnterTransition(state, transition.toParams, transition.reloadStateTree, reloaded);
             reloaded = reloaded || type === 'reload';

diff --git a/test/stickySpec.js b/test/stickySpec.js
@@ -195,6 +195,12 @@ describe('stickyState', function () {
       testGo('A', {exited: ['A._2', 'A._1', 'A._3']});
       testGo('main', { entered: ['main'], exited: ['A']});
     });
+
+    it('should allow empty transitionTo options', function() {
+      expect(function() {
+        $state.transitionTo('A')
+      }).not.toThrow()
+    })
   });
 
   describe('resolve/controller function', function () {