Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore SSL errors #6

Closed
eschultze opened this issue Apr 5, 2018 · 1 comment
Closed

Add option to ignore SSL errors #6

eschultze opened this issue Apr 5, 2018 · 1 comment

Comments

@eschultze
Copy link

eschultze commented Apr 5, 2018

First of all thanks for your project!

Sometimes screenshots will fail if the SSL certificate was not issued by a CA or if it's expired. This example is a phishing website from Phishtank.

$ sitescan http://flordeyd.beget.tech/hopz/6dbc4//
• Launching chrome...
✔ Done.

• Loading http://flordeyd.beget.tech/hopz/6dbc4//...
• Error loading http://flordeyd.beget.tech/hopz/6dbc4//
(node:6098) UnhandledPromiseRejectionWarning: Error: SSL Certificate error: ERR_CERT_DATE_INVALID
    at NavigatorWatcher.waitForNavigation (/usr/local/lib/node_modules/site-scan/node_modules/puppeteer/lib/NavigatorWatcher.js:73:20)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
(node:6098) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:6098) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I wanted to help more but my node and js knowledge is not very good.

Check these links if you don't mind:
puppeteer/puppeteer#1088
puppeteer/puppeteer#1137
puppeteer/puppeteer#84

@christopherwk210
Copy link
Owner

Fixed in 04e8822 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants