New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to ignore certificate errors during navigation #84
Comments
naming pedantry: SSL (which is dead and now really TLS these days) is about the connection, whereas certificates are about identification. So it turns out certificate errors aren't really TLS issues. In order to simplify all this, folks normally just call the whole kit-and-kaboodle "HTTPS" which seems generally agreeable. So I'd start with calling this |
Thanks Paul! I like the |
It would be troublesome to implement this per navigation; i'm leaning towards the page.setIgnoreHTTPSErrors(true); |
I'd urge it be more tedious to ignore per navigation since you really shouldn't be ignoring problems like that. Even in a test suite, it's not something to encourage. |
@Garbee do you have any api suggestion? Having the setter on the page level would allow one to ignore HTTPS errors for the renderer-initiated navigations (those initiated with javascript's |
hmm. If the page level API solves a problem that the navigation function level doesn't, then that's the way to go. I simply didn't want to see it as "cleaner" than needing to repeat it on all the manual navigation from the puppeteer script. |
This patch implements Page.setIgnoreHTTPSErrors method. Fixes #84.
More details on this. This would result in inability to do Upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=751204. We spent half a day with @allada debugging the issue but it didn't get us anywhere. To move on with this, since there's no practical need to do const {Browser} = require('puppeteer');
const browser = new Browser({ignoreHTTPSErrors: true});
... |
This patch implements Browser 'ignoreHTTPSErrors' option. Fixes #84.
This patch implements Browser 'ignoreHTTPSErrors' option. Fixes #84.
There should be a capability to ignore certificate errors during navigation. See #66 for proposal and cyrus-and/chrome-remote-interface#183 for original discussion.
For example, we can add
ignoreSSL
navigation option:The text was updated successfully, but these errors were encountered: