Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pitch envelope export and improving auto pitch envelope #488

Merged

Conversation

davidhealey
Copy link
Contributor

I've made it so the first and last node of the auto generated pitch envelope is set to 0.5 after the table is reset.

After the table is generated the first node is set to be the same as the second node. I've found in practice that it works out well, rather than leaving it at 0.5.

I've also set it to remove any nodes that are 0.0 or 1.0 because otherwise I've found that the envelope always includes a few random 0s and 1s at the start and end which I was getting RSI from removing :)

I've added optional arguments to set the sample rate and bit depth for the CompressionHelpers::dump function so that when using the Apply sample map properties to sample files tool we can use the sample rate and bit depth of the original samples. When no sample rate or bit depth is provided to the function it will default to 44100/16 which were the previously hardcoded values.

@christoph-hart christoph-hart merged commit a8d3f51 into christophhart:develop May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants