Fixing pitch envelope export and improving auto pitch envelope #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made it so the first and last node of the auto generated pitch envelope is set to 0.5 after the table is reset.
After the table is generated the first node is set to be the same as the second node. I've found in practice that it works out well, rather than leaving it at 0.5.
I've also set it to remove any nodes that are 0.0 or 1.0 because otherwise I've found that the envelope always includes a few random 0s and 1s at the start and end which I was getting RSI from removing :)
I've added optional arguments to set the sample rate and bit depth for the CompressionHelpers::dump function so that when using the
Apply sample map properties to sample files
tool we can use the sample rate and bit depth of the original samples. When no sample rate or bit depth is provided to the function it will default to 44100/16 which were the previously hardcoded values.