Skip to content

Commit

Permalink
rntester Android > Don't call rncore_ModuleProvider(name, params) twi…
Browse files Browse the repository at this point in the history
…ce (facebook#40758)

Summary:

This is a follow up to facebook#39987

As we already call
```
  return rncore_ModuleProvider(name, params);
```
in:
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55

we don't have to do it again in:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D50109991
  • Loading branch information
christophpurrer authored and facebook-github-bot committed Oct 11, 2023
1 parent b13ea17 commit 8b2407a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/rn-tester/android/app/src/main/jni/OnLoad.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
#include <react/renderer/components/AppSpecs/ComponentDescriptors.h>
#include <react/renderer/components/legacyviewmanagerinterop/UnstableLegacyViewManagerInteropComponentDescriptor.h>
#include <rncore.h>

namespace facebook {
namespace react {
Expand Down Expand Up @@ -50,7 +49,7 @@ std::shared_ptr<TurboModule> javaModuleProvider(
if (module != nullptr) {
return module;
};
return rncore_ModuleProvider(name, params);
return nullptr;
}

} // namespace react
Expand Down

0 comments on commit 8b2407a

Please sign in to comment.