Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the RSS feed #39

Closed
SamuelNitsche opened this issue May 19, 2021 · 12 comments
Closed

Implementation of the RSS feed #39

SamuelNitsche opened this issue May 19, 2021 · 12 comments
Assignees

Comments

@SamuelNitsche
Copy link
Contributor

I just took a look at the rss feed and noticed that this does not really make sense for this kind of application.

Rss feeds are generally used for items published in the past. The streams are upcoming items.

The current implementation uses the updated_at field of each stream as the publish date which displays upcoming streams as published at a date in the past.

If we use the real scheduled_start_time, most rss readers will use the current time or only display the items once the scheduled_start_time is in the past.

This is how the current stream is displayed in Reeder 5.
IMG_0033

@christophrumpel
Copy link
Owner

Thanks, @SamuelNitsche. I don't use RSS feeders. I just pushed a commit to provide tests for the current solution. (so we have a base to refactor) and I removed the dummy summary with the description.

Would you use the RSS feed for such an application?

@SamuelNitsche
Copy link
Contributor Author

In general I would use the feed but I can't think of a way to get it working well.

@christophrumpel
Copy link
Owner

@freekmurze any ideas what could be a good solution here?

@freekmurze
Copy link
Collaborator

@SamuelNitsche couldn't we use the stream creation date as the publish date of a feed item? This way you would see it in your RSS reader as soon as the stream is created.

Feel free to submit a PR for this 👍

@SamuelNitsche
Copy link
Contributor Author

@freekmurze That's what I already tried. The problem of this approach is that most rss readers display the current date instead of the date in the future. So you see a stream that starts tomorrow but the feed says it starts now.

@christophrumpel
Copy link
Owner

@freekmurze any idea of a better solution? I will implement an archive for this app soon, maybe it makes more sense to create the RSS feed for only past streams?

@freekmurze
Copy link
Collaborator

I'm thinking it is just a matter of clear copy. The creation date of the RSS item shouldn't necessarily be the start of the stream. In the body of the feed item you could mention the real start date of the stream.

@SamuelNitsche
Copy link
Contributor Author

Is there a real benefit of the rss feed then? I think the main goal of larastreamers is to have a place to see all streams (in the future).

@freekmurze
Copy link
Collaborator

Yeah, personally I'd love to see announcements in my RSS reader so that I don't have to visit the site. But ultimately @christophrumpel decides if it's worth it for him 👍

@christophrumpel
Copy link
Owner

If it benefits you @freekmurze, we should keep it for sure. Since the app is about upcoming streams, we should try to make it work for those also in the RSS feed.

So how can we improve the current implementation? Anyone up for a PR for that?

@GertjanRoke
Copy link

What about a Telegram channel instead? Something like Laravel News has.

@christophrumpel
Copy link
Owner

For me, this is very hard to tell since I don't use an RSS reader.

Please @freekmurze decide how it works best.

@GertjanRoke Telegram could be interesting too, but probably not yet.

Repository owner locked and limited conversation to collaborators Dec 8, 2021
@christophrumpel christophrumpel converted this issue into discussion #127 Dec 8, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants