Refactor all characters filters

christophrumpel · May 9, 2015 · e9d664c · e9d664c
1 parent d945c80
commit e9d664c
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/SuperheroApi.php b/src/SuperheroApi.php
@@ -44,21 +44,17 @@ public function __construct($publicKey, $privateKey)
 
     /**
      * Get all Marvel characters
-     * @param int $offset
-     * @param int $limit
+     * @param array $filterAttributes
      * @return mixed
      */
-    public function getAllCharacters($offset = 0, $limit = 0)
+    public function getAllCharacters(array $filterAttributes = [])
     {
         $filters = [
             'query' => [
-                'offset' => $offset,
+                $filterAttributes
             ]
         ];
 
-        if($limit > 0)
-            $filters['query']['limit'] = $limit;
-
         try {
             $result = $this->client->get('characters', $filters);
         } catch (RequestException $e) {