New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genhol.R - event.st.added not found #261

Closed

FransAndersen opened this issue Mar 30, 2021 · 1 comment · Fixed by #285

Labels

bug

FransAndersen commented Mar 30, 2021 •

edited

holiday     <- timeDate::holiday(year=1993:2021, Holiday='NewYearsDay')
holiday.reg <- seasonal::genhol(x = as.Date(holiday), frequency = 12, center = "calendar")

Error in cut(event.st.added, by, labels = F) : 
  object 'event.st.added' not found

It looks like event.st.added is declared inside an if-statement but used outside, see row 206 and 216 in genhol.R

The text was updated successfully, but these errors were encountered:

Owner

christophsax commented Sep 17, 2021

You are right, thanks! Will fix.

christophsax added the bug label

christophsax added a commit that referenced this issue


          January first can be used in genhol() #261

1830d5e

christophsax mentioned this issue

Merged

christophsax closed this as completed in #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment