Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

feat(errors): adds error handling that will terminate the node process. #232

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

cbravo
Copy link
Contributor

@cbravo cbravo commented Aug 13, 2018

prior to this PR whenever the prerender plugin would fail and throw the error

[prerender-spa-plugin] Unable to prerender all routes!

but the build would continue successfully. This caused big problems for CI/CD platforms that rely on the process to exit so the build process can fail.

@JoshTheDerf JoshTheDerf merged commit 1d6188e into chrisvfritz:master Aug 14, 2018
@cbravo cbravo deleted the feat-error-handling branch August 14, 2018 00:36
@cbravo
Copy link
Contributor Author

cbravo commented Aug 14, 2018

@tribex just one follow up to all this.... when can I expect the NPM package to be updated with this merge?

@JoshTheDerf
Copy link
Collaborator

@cbravo as soon as I have a chance to update it. Hopefully tonight but no promises. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants