-
Notifications
You must be signed in to change notification settings - Fork 633
FIX : for some reasons, injecting core-js is not always in this relat… #54
Conversation
…ive path. This may be better to specify the relative from a well known one : the one from the current script This should fix the bug encountered by many customers : #23
I was having the same problem and can confirm that this solved the issue |
I was seeing the same problem. Changing that line, and confirming that core-js was installed fix the problem right up. |
This looks OK @chrisvfritz. What is the procedure for maintainers to merge PR's, issue a new semver, etc? Do you prefer merge or rebase? |
This also worked for me. |
@chrisvfritz tested on macOs and windows. This worth being merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for getting to this late!
Looks great. 💯
This also fixes this #23 |
@alanaasmaa - thanks for the +1; this will make it into the next release. |
@drewlustro Just let me know when we're ready for the next release. 🙂 |
@chrisvfritz - This PR may be closed ✅ . It has been merged into the release we performned last week. |
…ive path. This may be better to specify the relative from a well known one : the one from the current script
This should fix the bug encountered by many customers : #23