Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

FIX : for some reasons, injecting core-js is not always in this relat… #54

Merged
merged 1 commit into from Jul 14, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2017

…ive path. This may be better to specify the relative from a well known one : the one from the current script

This should fix the bug encountered by many customers : #23

…ive path. This may be better to specify the relative from a well known one : the one from the current script

This should fix the bug encountered by many customers : #23
@heinzdmx
Copy link

heinzdmx commented Apr 4, 2017

I was having the same problem and can confirm that this solved the issue

@willtpwise
Copy link

I was seeing the same problem. Changing that line, and confirming that core-js was installed fix the problem right up.

@drewlustro
Copy link
Collaborator

This looks OK @chrisvfritz.

What is the procedure for maintainers to merge PR's, issue a new semver, etc?

Do you prefer merge or rebase? package.json updates in the same PR? Please advise your preference.

@alanaasmaa
Copy link

This also worked for me.

@ghost
Copy link
Author

ghost commented Jun 24, 2017

@chrisvfritz tested on macOs and windows. This worth being merged!

Copy link
Collaborator

@drewlustro drewlustro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for getting to this late!

Looks great. 💯

@drewlustro drewlustro merged commit c5b1376 into chrisvfritz:master Jul 14, 2017
@alanaasmaa
Copy link

This also fixes this #23

@drewlustro
Copy link
Collaborator

@alanaasmaa - thanks for the +1; this will make it into the next release.

@chrisvfritz
Copy link
Owner

@drewlustro Just let me know when we're ready for the next release. 🙂

@drewlustro
Copy link
Collaborator

@chrisvfritz - This PR may be closed ✅ . It has been merged into the release we performned last week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants